update chainlink-common#22673
Conversation
There was a problem hiding this comment.
Pull request overview
Bumps chainlink-common (and related modules keystore, chipingress, chainlink-protos/cre/go) and transitive deps (golang.org/x/{crypto,net,sys}, addition of go.opentelemetry.io/contrib/bridges/prometheus, gorilla/{handlers,mux}; removal of stellar/* and xdrpp/goxdr). Uses a newly available helper from chainlink-common/keystore/corekeys/ocr2key to populate the new OnchainSigningAddressPubKey field on the OCR2 key bundle protobuf message.
Changes:
- Update
chainlink-common,chainlink-common/keystore,chainlink-common/pkg/chipingress, andchainlink-protos/cre/gomodule versions. - Adjust transitive dependencies (
golang.org/x/*bumps, added otel prometheus bridge and gorilla handlers/mux, removed stellar/goxdr). - In
newOCR2ConfigMsg, populateOnchainSigningAddressPubKeyvia the newocr2key.RawEVMOnChainPublicKeyhelper when available.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Version bumps for chainlink-common modules, cre protos, and x/crypto; updated indirect deps. |
| go.sum | Corresponding checksum updates for the dependency changes. |
| core/services/feeds/service.go | Imports ocr2key and sets OnchainSigningAddressPubKey on the OCR2 key bundle protobuf. |
|
I see you updated files related to
|
|
✅ No conflicts with other open PRs targeting |
| OffchainPublicKey: hex.EncodeToString(ocrOffChainPublicKey[:]), | ||
| OnchainSigningAddress: ocrKey.OnChainPublicKey(), | ||
| } | ||
| if rawPubKey, ok := ocr2key.RawEVMOnChainPublicKey(ocrKey); ok { |
There was a problem hiding this comment.
I think we should add some tests
|
Requires
Supports