Skip to content

Remove an #[allow(unnecessary_unwrap)]#644

Merged
ltratt merged 1 commit into
softdevteam:masterfrom
ratmice:more_unnecessary_unwrap
Jul 12, 2026
Merged

Remove an #[allow(unnecessary_unwrap)]#644
ltratt merged 1 commit into
softdevteam:masterfrom
ratmice:more_unnecessary_unwrap

Conversation

@ratmice

@ratmice ratmice commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

This just attempts to remove some allow lints, but slightly modifying the code to not need it anymore.
I'm not sure if this one will conflict with the clippy patch. If it does I will rebase one or the other not a big deal.

@ltratt
ltratt added this pull request to the merge queue Jul 12, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 12, 2026
@ratmice
ratmice force-pushed the more_unnecessary_unwrap branch from 25bced5 to d2d0072 Compare July 12, 2026 22:02
@ratmice

ratmice commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator Author

rustfmt & squashed that.

@ltratt
ltratt added this pull request to the merge queue Jul 12, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 12, 2026
@ratmice

ratmice commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator Author

This ran fine with my old version of cargo-deny, until I upgraded,
cargo-deny check license appears to no longer work, and the correct command appears to be pluralized
cargo-deny check licenses, I'll make a PR for CI

@ltratt
ltratt added this pull request to the merge queue Jul 12, 2026
Merged via the queue into softdevteam:master with commit 14c7442 Jul 12, 2026
2 checks passed
@ratmice
ratmice deleted the more_unnecessary_unwrap branch July 13, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants