Fix typo, and test in cttests#647
Merged
Merged
Conversation
ratmice
commented
Jul 16, 2026
| None => None, | ||
| }; | ||
| let recoverer = match docs[0]["revoverer"].as_str() { | ||
| let recoverer = match docs[0]["recoverer"].as_str() { |
Collaborator
Author
There was a problem hiding this comment.
I guess we should learn our lesson here and add a Some(_) => panic!("Unknown recovery kind")
Collaborator
Author
There was a problem hiding this comment.
Should be fixed in 72afa11
I didn't see anything else that wasn't checking for unrecognized Some(_) values.
Member
|
Good find! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was expecting to run with a recoverer. So fixing the typo, broke the test.
Because of the typo it was falling back to the default (CPCTPlus).