fix: protect RedisStore.mutex map from concurrent access#120
Open
123456wda wants to merge 1 commit into
Open
Conversation
The mutex map in Store is accessed concurrently by Lock() and Unlock() without any synchronization. Since Go maps are not safe for concurrent writes, this causes a data race when multiple DistributedCircuitBreaker instances share the same Store and call Lock/Unlock with different keys concurrently. Add a sync.Mutex to protect all map operations in Lock() and Unlock(). The map mutex is released before calling redsync operations to avoid holding it during potentially blocking network calls. Verified with: go test -race ./v2/redis/...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
mutexfield inredis.Store(map[string]*redsync.Mutex) is accessed concurrently byLock()andUnlock()without any synchronization. Go maps are not safe for concurrent read/write — this causes a data race when multipleDistributedCircuitBreakerinstances share the sameStoreand callLock/Unlockwith different keys concurrently.Reproduction
The existing
TestRedisStore_Concurrent_Lockstest covers this scenario but CI runsgo test -vwithout-race, so the race is not detected.Fix
Add a
sync.Mutexto theStorestruct to protect all map operations inLock()andUnlock(). The map mutex is released before calling redsync operations to avoid holding it during potentially blocking network calls.type Store struct { ctx context.Context client redis.UniversalClient rs *redsync.Redsync + mu sync.Mutex mutex map[string]*redsync.Mutex }Verification
All existing tests pass with the race detector enabled.