Add MathSAT5 logic selection via option#670
Open
baierd wants to merge 11 commits into
Open
Conversation
…configuration returns
…it an unsat query
…t more complex and instead handle better error messages in JavaSMT directly
… invalid logic name (mathsat seems to ignore them)
baierd
marked this pull request as ready for review
June 8, 2026 16:57
Contributor
Author
|
MathSAT5 needs to be updated in our Ivy/Maven repos before this can be merged. But everything is tested locally and seems to work fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds context wide (i.e. all provers created from a certain context) logic selection via a new option for MathSAT5 with tests. This adds a new function to the wrapper and MathSAT5 needs to be recompiled and re-published for this PR.