Add support for eldarica horn solver#683
Open
Bixilon wants to merge 69 commits into
Open
Conversation
This is most certainly not the intended way, the `ivy.xml` adds multiple repository. But good enough for now until eldarica is published to https://www.sosy-lab.org/ivy/uuverifiers/
…uld be at the start of the smt2 file to be parsed set by private helper method `sanitize` in `AbstractFormulaManager`.
This makes it easy to create horn clauses in the form: `(constraint \/ body) => head`.
This makes it easy to create horn clauses in the form: `(constraint \/ body) => head`.
This makes it easy to create horn clauses in the form: `(constraint \/ body) => head`.
This is most certainly not the intended way, the `ivy.xml` adds multiple repository. But good enough for now until eldarica is published to https://www.sosy-lab.org/ivy/uuverifiers/
This is just an alias for `PRINCESS` at the moment, as eldarica builds up on princess and is just the horn prover environment.
…arica # Conflicts: # .idea/JavaSMT.iml
This is needed for smtlib2 parsing (and evaluation for me :P)
ported over from master
Taken from CHC comp and the other one is a refactored one from one example page for CHC horn clauses, don't remember the actual source anymore :(
Somehow they still fail...
Took me 2 days to find it...
they might get optimized out with `andSimplify` and produce wrong results.
# Conflicts: # src/org/sosy_lab/java_smt/basicimpl/Tokenizer.java
baierd
reviewed
Jul 9, 2026
baierd
reviewed
Jul 9, 2026
|
|
||
| @Override | ||
| protected @Nullable IExpression evalImpl(IExpression formula) { | ||
| throw new UnsupportedOperationException(); // TODO? |
Contributor
There was a problem hiding this comment.
@Bixilon
Hint: implementing this helps you finishing getAssignments() above more easily.
Collaborator
Author
There was a problem hiding this comment.
I implemented this without the evalImpl, I am not really sure how to implement eval properly. Is this really needed? I am getting the value assignments.
baierd
reviewed
Jul 9, 2026
baierd
reviewed
Jul 9, 2026
baierd
reviewed
Jul 9, 2026
Co-authored-by: BaierD <daniel.baier@sosy.ifi.lmu.de>
Co-authored-by: BaierD <daniel.baier@sosy.ifi.lmu.de>
Daniel apparently does not like this, see #683 (comment) Co-authored-by: BaierD <daniel.baier@sosy.ifi.lmu.de>
This uses princess to evaluate the formula. Might not be perfect, as not all edge cases might be covered (but then it will just throw the exception)
Bixilon
marked this pull request as ready for review
July 19, 2026 14:06
Bixilon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
provide_javasmt_main_to_execute_as_solver_for_smt-comp@gcarpio21 (it works and is not bad, but we can also revert it)2025-11-17to2026-05-20); required for eldarica