Fix WPML listing visibility across translated languages#13
Open
Arafat-plugins wants to merge 9 commits into
Open
Fix WPML listing visibility across translated languages#13Arafat-plugins wants to merge 9 commits into
Arafat-plugins wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
This PR fixes Directorist WPML integration issues where translated listings and directory data were not resolving correctly outside the default English language.
Client-reported issue:
/fr/toutes-les-inscriptions/, shows0 Listings Found.What changed:
_directory_typemeta queries so translated directory type IDs are included instead of only the default-language ID.Directory_Type_Meta_Translationto translate_directory_typepost and term metadata according to the current WPML language.term_idand WPMLterm_taxonomy_idcorrectly.wpml-config.xmlso Directorist/WPML field configuration is more complete for translated directory/listing data.2.2.3, includingreadme.txt,README.md, plugin header, changelog, compatibility notes, and.distignorepackage exclusions.How to test the changes:
/fr/toutes-les-inscriptions/.0 Listings Found.Before this change:
0 Listings Foundeven when translated listings existed.After this change:
2.2.3.Testing Result
bug-fixwas created from the latestupstream/main.wpml-config.xmlparsed successfully as valid XML.git diff --checkpassed. Only normal Windows CRLF normalization warnings were reported.2.2.3matches readme stable tag2.2.3.2.2.3.bn,en,fr,de,ro.138checks,0failures.6non-fatal warnings from WordPress/Directorist core CLI rendering context, not from this integration plugin.Any linked issues
Fixes: https://taiga-sovware-u10698.vm.elestio.app/project/directorist/issue/2903
Screenshot
Checklist