chmod and chown support#16
Open
dipcore wants to merge 2 commits into
Open
Conversation
Owner
|
Might be a good idea to use |
Author
|
yes, right, added |
Author
|
Hm, found one more interesting thing, it seems like it looses permissions, if I try to edit a file. Don't you mind, if I add a debug mode and logging to syslog instead of cout ? |
Author
|
What I see in logs if I try to save it: So the problem seems in the last adb push |
Owner
|
Looks like adb push resets the permissions. Might need to come up with a scheme to preserve them in the dictionary then chmod after the push. |
chen3feng
added a commit
to chen3feng/adbfs
that referenced
this pull request
Jun 28, 2026
Two related macOS write-path fixes: chmod/chown (backport of spion#16, with the path properly single-quoted -- the original left it unquoted and broke on paths with spaces). Implementing chmod also stops `cp -p`/copyfile failing with "fchmod failed: Function not implemented". Extended-attribute ops (get/set/list/removexattr) that accept and discard. adbfs can't persist xattrs on the device, but implementing these makes the volume advertise native xattr support, so macOS stores its metadata via setxattr (which we drop) instead of scattering AppleDouble "._" sidecars over the phone -- and cp/cp -p stop failing on the extended-attribute copy. Verified on a device: with macFUSE, cp/cp -p/ditto/redirect all exit 0 and no ._ files appear; data md5 matches. On fuse-t (NFS-backed) the copies also stop erroring, though ._ files still appear since NFS bypasses the xattr ops. Builds clean against both macFUSE and fuse-t. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.