Add full stat capabilities, fixed utimens and managing old or exotic Android OSes#79
Open
Vahlblue wants to merge 9 commits into
Open
Add full stat capabilities, fixed utimens and managing old or exotic Android OSes#79Vahlblue wants to merge 9 commits into
Vahlblue wants to merge 9 commits into
Conversation
Co-authored-by: Gjorgji Kjosev <gorgi.kosev@gmail.com>
Co-authored-by: Gjorgji Kjosev <gorgi.kosev@gmail.com>
Co-authored-by: Gjorgji Kjosev <gorgi.kosev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Here is a PR that implements all stat attributes for adb_getattr and fixes my last PR #76 utimens for all cases.
It handles :
Tested on :
For those devices I tested that a touch and a stat always output the same information and that other features are working.
I used my modification to sync to the second all my files of all my devices to be able to sync on my NAS.
To be noted : from Android 6 to 8 utimens cannot work due to a bug in the old toybox coreutils (details in the code comments). They is no workaround possible. The only way is a rooted device and busybox for example installed which will be automatically chosen by the detections capabilities.
Since it comes at a cost of performance (all file must be individually stated) we could imagine some solutions :
adb shellsession continuously.