Stop interactive shell runner on context close#1356
Conversation
|
Thank you for the PR. I quickly tested the change, and it seems to fix the issue. However, the first run of any command still fails, but subsequent calls succeed. Here is the output I get with the sample here when I run it in IntelliJ IDEA: I am not sure if the sample mimics exactly how devtools work, so I will check with the devtools plugin itself and get back to you (I don't want to waste time trying to fix an issue that does not happen with devtools). Also, typing |
Resolves spring-projects#1224 Signed-off-by: David Pilar <david@czpilar.net>
ed969b8 to
eaaec1c
Compare
Signed-off-by: David Pilar <david@czpilar.net>
|
@fmbenhassine I can reproduce it too. The dropped first character is a leftover JLine reader thread. With the dumb terminal (IDE/Gradle), JLine reads stdin on a background thread blocked in a native read on Fix: create the terminal once per JVM and reuse it across context restarts, so there's only ever one reader of stdin (closed on JVM shutdown instead of on context close). The first command now works on the first try. |
Resolves #1224