Add ok_to_test label that will be used by Zuul#535
Conversation
See stackhpc/stackhpc-zuul-config#71 Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a new github_issue_label resource called ok_to_test_label across all configured repositories. The feedback suggests extracting the repeated complex expression toset(flatten(values(var.repositories))) into a local variable to enhance readability and maintainability.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| } | ||
|
|
||
| resource "github_issue_label" "ok_to_test_label" { | ||
| for_each = toset(flatten(values(var.repositories))) |
There was a problem hiding this comment.
The complex expression toset(flatten(values(var.repositories))) is repeated multiple times in this file (e.g., here and in the data "github_repository" "repositories" block).
To improve maintainability and readability, consider defining a local variable for this set of repository names, such as:
locals {
all_repositories = toset(flatten(values(var.repositories)))
}And then reference it as local.all_repositories here and in the data source.
for_each = local.all_repositories
See stackhpc/stackhpc-zuul-config#71