Skip to content

Add ok_to_test label that will be used by Zuul#535

Open
mnasiadka wants to merge 1 commit into
mainfrom
ok_to_test
Open

Add ok_to_test label that will be used by Zuul#535
mnasiadka wants to merge 1 commit into
mainfrom
ok_to_test

Conversation

@mnasiadka

Copy link
Copy Markdown
Member

See stackhpc/stackhpc-zuul-config#71

Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new github_issue_label resource called ok_to_test_label across all configured repositories. The feedback suggests extracting the repeated complex expression toset(flatten(values(var.repositories))) into a local variable to enhance readability and maintainability.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

}

resource "github_issue_label" "ok_to_test_label" {
for_each = toset(flatten(values(var.repositories)))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The complex expression toset(flatten(values(var.repositories))) is repeated multiple times in this file (e.g., here and in the data "github_repository" "repositories" block).

To improve maintainability and readability, consider defining a local variable for this set of repository names, such as:

locals {
  all_repositories = toset(flatten(values(var.repositories)))
}

And then reference it as local.all_repositories here and in the data source.

  for_each    = local.all_repositories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant