Skip to content

Prepare privacy crates for crates.io publishing#372

Closed
gilbens-starkware wants to merge 1 commit into
mainfrom
gil/publish-privacy-crates
Closed

Prepare privacy crates for crates.io publishing#372
gilbens-starkware wants to merge 1 commit into
mainfrom
gil/publish-privacy-crates

Conversation

@gilbens-starkware

@gilbens-starkware gilbens-starkware commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Prepares the privacy crates (privacy-prove, privacy-circuit-verify) for publishing to crates.io.

  • Completes publish metadata on both privacy crates: homepage.workspace = true, keywords, categories.
  • Adds homepage to [workspace.package] so all crates inherit it.
  • Fixes publish-script ordering: privacy-circuit-verify now publishes before privacy-prove (privacy-prove depends on it; the reverse edge is a dev-dependency only, so no cycle). Final order: cairo-program-runner-lib → cairo-program-runner → privacy-circuit-verify → privacy-prove → stwo-vm-runner → stwo-run-and-prove.

⚠️ Depends on upstream publishes

Both privacy crates pull the stwo-circuits crate family (circuit-*, circuits) and the stwo-cairo crates via git revs. Those must be published to crates.io first, then these git deps swapped for version deps.

Also flagged for a follow-up: the [workspace.dependencies] entries for cairo-program-runner-lib and privacy-circuit-verify are pinned version = "1.0.0" while the crates carry 1.2.2 — reconcile before publishing.

Final link in the chain: stwo 2.3.0 → stwo-cairo 1.3.0 → stwo-circuits 1.0.0 → proving-utils privacy crates.

🤖 Generated with Claude Code


This change is Reviewable

Complete publish metadata for privacy-prove and privacy-circuit-verify
(homepage, keywords, categories), add homepage to [workspace.package],
and fix the publish script ordering so privacy-circuit-verify is
published before privacy-prove (privacy-prove depends on it; the reverse
edge is only a dev-dependency).

Note: both crates depend on git revs of the stwo-circuits and stwo-cairo
crate families, which must be published to crates.io first.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@cursor

cursor Bot commented Jun 24, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Metadata and publish-script ordering only; no runtime or cryptographic logic changes.

Overview
Adds crates.io metadata for the privacy crates and aligns automated publishing with their dependency graph.

Workspace: [workspace.package] now includes homepage so member crates can inherit it via homepage.workspace = true.

privacy-prove and privacy-circuit-verify: Each gains homepage, keywords (cairo, stwo, stark, zero-knowledge, privacy), and categories (cryptography; privacy-prove also lists command-line-utilities).

scripts/publish_workspace_crates.sh: Publish order swaps so privacy-circuit-verify runs before privacy-prove, matching the runtime dependency (privacy-prove depends on privacy-circuit-verify; the reverse link is dev-only).

Reviewed by Cursor Bugbot for commit 8f8c8f8. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.29%. Comparing base (bd02ec9) to head (8f8c8f8).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
+ Coverage   60.39%   64.29%   +3.89%     
==========================================
  Files          36       39       +3     
  Lines        5333     5613     +280     
==========================================
+ Hits         3221     3609     +388     
+ Misses       2112     2004     -108     

see 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gilbens-starkware

Copy link
Copy Markdown
Contributor Author

Superseding: re-basing this prep onto the exact revs pinned by proving-utils tag v0.14.3-rust-bump (to publish that snapshot). A replacement PR will follow.

@gilbens-starkware gilbens-starkware deleted the gil/publish-privacy-crates branch June 25, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant