Skip to content

deployment,apollo_deployments: drop config_format plumbing and retire preset config path #14646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nimrod-starkware wants to merge 1 commit into
base: nimrod/jsonnet/testing-overlays-native-layers
Choose a base branch
from
Open

deployment,apollo_deployments: drop config_format plumbing and retire preset config path #14646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions deployments/sequencer/src/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ def main():
monitoring_configs["enabled"],
args.layout,
args.overlay or [],
args.config_format,
)
_create_monitoring_chart(app, namespace, args.cluster, monitoring_configs)

Expand Down Expand Up @@ -189,7 +188,6 @@ def _create_service_charts(
monitoring_enabled: bool,
layout: str,
overlays: list[str],
config_format: str,
):
"""Create SequencerNodeChart for each service."""
for service_cfg in deployment_config.services:
Expand All @@ -201,7 +199,6 @@ def _create_service_charts(
service_config=service_cfg,
layout=layout,
overlays=overlays,
config_format=config_format,
)


Expand Down
5 changes: 0 additions & 5 deletions deployments/sequencer/src/charts/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,11 @@ def __init__(
service_config: ServiceConfig,
layout: str,
overlays: list[str],
config_format: str,
):
super().__init__(scope, name, disable_resource_name_hashes=True, namespace=namespace)

self.monitoring = monitoring
self.service_config = service_config
self.config_format = config_format

# Create labels dictionary from service config + service name
# Base labels from shared config (metaLabels) - now merged into service_config
Expand All @@ -57,7 +55,6 @@ def __init__(
monitoring_endpoint_port,
layout,
overlays,
config_format=config_format,
)

# Create ServiceAccount if enabled
Expand Down Expand Up @@ -104,7 +101,6 @@ def __init__(
service_config=self.service_config,
labels=labels,
monitoring_endpoint_port=monitoring_endpoint_port,
config_format=config_format,
)
else:
self.controller = DeploymentConstruct(
Expand All @@ -113,7 +109,6 @@ def __init__(
service_config=self.service_config,
labels=labels,
monitoring_endpoint_port=monitoring_endpoint_port,
config_format=config_format,
)

# Create BackendConfig if enabled
Expand Down
10 changes: 0 additions & 10 deletions deployments/sequencer/src/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,16 +75,6 @@ def argument_parser():
action=UniqueStoreAction,
help="Override image for all services. Format: 'repository:tag' or 'repository' (defaults to 'latest' tag).",
)
parser.add_argument(
"--config-format",
type=str,
action=UniqueStoreAction,
choices=["preset", "native"],
default="preset",
help="Node config format to emit and pass to the node container via --config_format. "
"'preset' (default): flat dotted-key placeholder fill (legacy). "
"'native': nested SequencerNodeConfig assembled via jsonnet build().",
)
parser.add_argument(
"-v",
"--verbose",
Expand Down
Loading
Loading