feat(reconcilers): implement manual editing reconciler#14
Merged
Conversation
nicolst
changed the title
johnksv
reviewed
Jun 5, 2026
johnksv
left a comment
johnksv
left a comment
Member
There was a problem hiding this comment.
Once again it comes down to naming discussion 😅 Functionality looks OK!
nicolst
force-pushed
the
manual-editing-reconciler
branch
from
5d9b364 to
c3f2dbb
Compare
johnksv
approved these changes
Jun 8, 2026
johnksv
left a comment
johnksv
left a comment
Member
There was a problem hiding this comment.
Looking good! One minor that is nice to fix
| return reconcilerName | ||
| } | ||
|
|
||
| func (r *reconciler) Reconcile(ctx context.Context, client *apiclient.APIClient, naisTeam *protoapi.Team, log logrus.FieldLogger) error { |
Member
There was a problem hiding this comment.
naisTeam 👀 (appears in Delete function signature as well)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.