Make sure verification URL is generated correctly#682
Merged
Conversation
tilen1976
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
While implementing Klass in SSB Dataportal, it was discovered that the pattern used for generating email subscription verification links relied on the host from the incoming request. This resulted in verification URLs using internal hosts such as
http://klass/, which made it impossible to verify subscriptions.Change
Replace the use of
WebMvcLinkBuilderwithUriComponentsBuilderwhen generating subscription verification and unsubscribe URLs.WebMvcLinkBuilderis useful for generating dynamic HATEOAS links based on the current request context. However, for links sent by email, the host should always resolve to the public environment URL. The new implementation generates URLs using the configured public base URL, ensuring that verification links always point to the correct public endpoint (data.ssb.noordata.test.ssb.no).Additional changes
SSB Dataportalin Klass api development manifestResult
Users now receive valid verification links that resolve to the public Klass endpoints, allowing email subscription verification to work correctly across environments.