Make domain parquet reader swappable via Protocol#137
Open
linnbjornerud wants to merge 1 commit into
Open
Conversation
|
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| return UnencryptedParquetReader() | ||
|
|
||
|
|
||
| def process_event_request( |
Collaborator
There was a problem hiding this comment.
What do you think about making it a DataReader (UnencryptedDataReader) that includes each of these process* functions, and then DI'ing the DataReader based on a factory function (similar to _get_parquet_reader)?
Contributor
Author
There was a problem hiding this comment.
I like the idea! I will test 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the domain data reading behind a
ParquetReaderProtocol.UnencryptedParquetReaderis now default implementation.This should make it easy to swap reader implementations, and serves as a preparation for the upcoming
EncryptedParquetReader, while keeping the current API behaviour unchanged.Ref the first checklistitem in issue #129.