fix(p2p): downgrade unlinkable block error to warning during sync#3711
Merged
Conversation
During blockchain synchronization, receiving blocks from forks is expected behavior as multiple peers may be on different forks. Previously, these were logged as errors via elog(), causing log noise and false alerts. This change: - Checks sync_mode in the unlinkable_block_exception handler - Uses fc_wlog (warning level) for sync mode instead of elog (error level) - Returns false immediately in sync mode, avoiding unnecessary exception propagation to node.cpp - Preserves existing error behavior for non-sync mode (triggers sync restart) Fixes: Error when pushing block elog noise during sync Reference: i-05d97adb280d9914e (steemit-production-steemd-002)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During blockchain synchronization, receiving blocks from forks is expected behavior as multiple peers may be on different forks. Previously, these were logged as errors via elog(), causing log noise and false alerts.
This change:
Fixes: Error when pushing block elog noise during sync
Reference: i-05d97adb280d9914e (steemit-production-steemd-002)