Skip to content

Fix: Keep cost history chart steady while hovering#2016

Merged
steipete merged 5 commits into
steipete:mainfrom
iam-brain:iam-brain/fix-stable-cost-history
Jul 10, 2026
Merged

Fix: Keep cost history chart steady while hovering#2016
steipete merged 5 commits into
steipete:mainfrom
iam-brain:iam-brain/fix-stable-cost-history

Conversation

@iam-brain

@iam-brain iam-brain commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Fixes #2015

Keeps the cost history chart in place while hovering days with different model counts.

  • sizes the model viewport to the busiest day in the displayed history, capped at four rows
  • keeps histories without model breakdowns compact
  • uses consistent row slots and keeps longer lists scrollable
  • shows a subtle “Scroll to see more models” hint on overflowing days
  • removes hover-driven AppKit host resizing

Validation on exact head 096521bd1586534e83aefb41b60f26a985763d7a:

  • focused cost-history, hosted-submenu, and localization suites: 53 tests passed
  • make check: SwiftFormat, SwiftLint, locale parity, parser hash, packaging, and repository checks passed
  • make test: all 50 local shards passed
  • autoreview: clean, patch correctness 0.91
  • Developer ID-signed debug bundle: strict codesign and Gatekeeper passed; bundled CLI reports 0.41.1
  • isolated synthetic CODEX_HOME: packaged CLI produced 1-, 4-, and 6-row days
  • live menu proof: the same submenu window stayed exactly 423×533 at (817,155) across all three hover states; the overflow hint appeared and scrolling revealed rows 5–6 without changing bounds
  • no real credentials, Keychain reads, browser sessions, or provider calls were used
Screenshot 2026-07-09 at 10 06 42 PM

@kiranmagic7

Copy link
Copy Markdown
Contributor

Checked the failing CI run on this head.

The cost-history change itself is reproducible locally:

  • swift test --filter CostHistoryChartMenuViewTests on 034fce43df1ad9e46acd1397c88df85710f02135: 14 tests passed.

The actionable blocker for this PR is the localization shard:

  • LocalizationLanguageCatalogTests expects full key parity for the strict catalogs.
  • This PR adds "Scroll to see more models" to ar, ca, en, fa, and th, but the strict catalogs still missing it are gl, tr, it, id, and pl. That matches the 5 localization issues in shard 1.
  • Adding the key to every catalog would also clear the lint-macos missing-localization warnings. The catalogs currently missing it are de, es, fr, gl, id, it, ja, ko, nl, pl, pt-BR, ru, sv, tr, uk, vi, zh-Hans, and zh-Hant.

The other failed shard looks unrelated to this diff:

@iam-brain

Copy link
Copy Markdown
Contributor Author
  • LocalizationLanguageCatalogTests expects full key parity for the strict catalogs.
  • This PR adds "Scroll to see more models" to ar, ca, en, fa, and th, but the strict catalogs still missing it are gl, tr, it, id, and pl. That matches the 5 localization issues in shard 1.
  • Adding the key to every catalog would also clear the lint-macos missing-localization warnings. The catalogs currently missing it are de, es, fr, gl, id, it, ja, ko, nl, pl, pt-BR, ru, sv, tr, uk, vi, zh-Hans, and zh-Hant.

Should now be fixed entirely by 3fe0ff0!

@iam-brain iam-brain changed the title Keep cost history chart steady while hovering Fix: Keep cost history chart steady while hovering Jul 10, 2026
@iam-brain iam-brain marked this pull request as ready for review July 10, 2026 01:14
@steipete steipete force-pushed the iam-brain/fix-stable-cost-history branch from 3fe0ff0 to 096521b Compare July 10, 2026 05:31
@steipete

Copy link
Copy Markdown
Owner

Maintainer proof for exact head 096521bd1586534e83aefb41b60f26a985763d7a:

  • Focused cost-history, hosted-submenu, and localization suites: 53 tests passed.
  • make check: passed, including formatting, lint, locale parity, parser hash, and packaging checks.
  • make test: all 50 local shards passed.
  • Autoreview: clean; no accepted/actionable findings.
  • Signed artifact: debug bundle uses Developer ID team Y5PE65HELJ; strict codesign and Gatekeeper passed; bundled helper reports CodexBar 0.41.1.
  • Source-blind live UI: isolated synthetic CODEX_HOME, packaged CLI row counts [1,4,6], no real credentials/Keychain/browser/provider access. The same cost submenu window remained 423×533 at (817,155) for 1-, 4-, and 6-row hover states. Overflow showed the scroll hint; dragging the real scrollbar revealed rows 5–6 without changing bounds.
  • Public Model Identifier Gate: PASS. The final diff introduces no public model identifier; test labels are clearly fictitious.
  • Dependency freshness: N/A; no dependency changes.

The contributor’s direction was retained, then tightened to preserve compact 36-point histories and use expanded rows only when the displayed range contains mode detail.

@clawsweeper

clawsweeper Bot commented Jul 10, 2026

Copy link
Copy Markdown

ClawSweeper status: review started.

I am starting a fresh review of this pull request: Fix: Keep cost history chart steady while hovering This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@steipete steipete merged commit 3491a35 into steipete:main Jul 10, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep the cost history chart steady while hovering days

3 participants