fix(ci): Missing edits, lake update#1440
Merged
Merged
Conversation
github-actions
Bot
added
the
dependencies
robin-aws
marked this pull request as ready for review
July 16, 2026 22:22
shigoel
approved these changes
Jul 16, 2026
github-actions
Bot
added
the
github_actions
The scripts were moved into a CBMC/ subdirectory but the relative path to PROJECT_ROOT was not updated (needs four levels up, not three).
robin-aws
changed the title
Parse.lean uses the @[noExponent] metadata attribute (declared in StrataDDM's StrataDDL dialect) but only imported BuiltinM, which doesn't transitively bring in StrataDDL. This caused the dialect elaboration to fail on a clean build (no cache), cascading into 'Unknown dialect' errors for all subsequent #dialect blocks.
This reverts commit 5073e76.
The cache restore was happening AFTER the docs/api build step. When the restore-keys fallback matched a stale cache (from before the StrataDDM rev update), it overwrote .lake/packages/StrataDDM/ with the old version, causing build failures in Parse.lean and Term.lean that reference features only available in the new StrataDDM (noExponent metadata, Hashable for Decimal). Moving the restore before the build ensures Lake re-fetches the correct StrataDDM version per lake-manifest.json, overwriting any stale cached packages.
New string operations (str.contains, str.indexof, str.replace, str.at, str.lt, str.le) were added to Core Grammar on main but the editor syntax files were not regenerated.
# Conflicts: # editors/emacs/core-st-mode.el # editors/vscode/syntaxes/core-st.tmLanguage.json
docs/api/lake-manifest.json pinned StrataDDM to the old rev (fbd9f71) while the root manifest uses 4ea13cd. Since docs/api uses packagesDir = '../../.lake/packages', building docs/api first fetches the OLD StrataDDM into the shared packages directory, which then causes the docs/verso build to fail (missing Hashable for Decimal, missing noExponent metadata attribute). Also update plausible to match the root manifest.
fabiomadge
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misses from the automation to push internal development to mainline:
lake updateto fetch a newer version of StrataDDM.lake lint