Only typecheck against a single version#1814
Open
xavdid wants to merge 2 commits into
Open
Conversation
prathmesh-stripe
approved these changes
May 25, 2026
Contributor
prathmesh-stripe
left a comment
prathmesh-stripe
left a comment
There was a problem hiding this comment.
It would've been nicer to pick this from our list of supported versions but this is fine for now.
Contributor
|
There are some static checks that are failing in Python 3.13 that we need to fix before we merge this. |
xavdid
changed the title
xavdid
commented
May 27, 2026
| if proxy: | ||
| if isinstance(proxy, str): | ||
| proxy = {"http": proxy, "https": proxy} | ||
| proxy = HTTPClient._Proxy(http=proxy, https=proxy) |
Member
Author
There was a problem hiding this comment.
this is more correct than the inline dict, which the typechecking on 3.13 caught!
Member
Author
|
@prathmesh-stripe good call! i've updated CI to only check against a single (modern) version. How does that look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
We used to typecheck a range of versions, but this wasn't actually adding much coverage. Ideally, we just check our types against a single modern version, since we get stricter checks. Incompatible syntax will be caught by unit tests, not type cehcks.
What?
typecheckjustfile recipeSee Also
#1764