fix(super-editor): rethrow export docx errors#3641
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
caio-pizzol
approved these changes
Jun 6, 2026
Contributor
caio-pizzol
left a comment
There was a problem hiding this comment.
@xy200303 thanks for the fix. I pushed a follow-up commit that covers the SuperDoc wrapper path and avoids duplicate export exception events.
The added coverage checks that a rejected editor export falls back to the original DOCX data, sibling documents still export, and a bridged editor exception does not cause a second wrapper exception.
I only ran git diff --check; local unit tests were not run because this repo asks us not to run them locally. CI is queued.
lgtm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Editor.exportDocx()errors after preserving the existing exception event and console logging.undefinedfrom the internal implementation return union.converter.exportToDocxcalls reject to the caller.Verification
pnpm test:editor -- src/editors/v1/tests/export/exportDocx.errors.test.jspnpm test:editor -- src/editors/v1/tests/export/exportDocx.errors.test.js src/editors/v1/tests/export/exportDocx.commentsFallback.test.jspnpm --prefix packages/super-editor run types:check(fails: existing unresolved@superdoc/font-systemdeclarations and broad pre-existing JS/TS errors)Closes #3579