SD-3352 - fix: refine deletion behavior for anonymous users in overlap-compiler#3655
Open
chittolinag wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…e-pending-insertion-should
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 326e79eab1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
In suggesting mode, deleting part of your own pending insertion should simply shrink the
suggestion - the way Word handles it. Instead, SuperDoc stacked a tracked deletion on top of your own insertion, as if another reviewer had crossed out your text: two overlapping review items for one intent.
This only happened in sessions without an identified user (no
userid/email passed by theintegrator). The editor handled differently each action: typing into your insertion used a permissive author check that recognizes an anonymous session as itself, but deleting inside it used the strict identity check. So the same user was "you" while typing and "someone else" the moment they deleted.
Repro
Comment out this line from
SuperdocDev.vueto simulate the default user.Proposed solution
Make deletion answer "is this my insertion?" exactly the way typing already does - one shared rule
(
isSameUserForRefinementinoverlap-compiler.js) for all same-user refinement: typing into,backspacing through, and now deleting inside your own pending insertion.
User-visible result: deleting inside your own suggestion shrinks it in place (deleting all of it
removes the suggestion entirely), with or without an identified user.
Review protection is untouched: other authors' suggestions - including named authors from imported Word files - still produce an independent, reviewable deletion, and accept/reject decisions still require strong identity.