jextract: support returning JavaKit wrapped Java objects (Resolves #841) - #851
Draft
amanmaurya92 wants to merge 1 commit into
Draft
jextract: support returning JavaKit wrapped Java objects (Resolves #841)#851amanmaurya92 wants to merge 1 commit into
amanmaurya92 wants to merge 1 commit into
Conversation
amanmaurya92
marked this pull request as draft
July 27, 2026 03:10
Contributor
|
I haven't read the code, but please also add some runtime tests to the JNI sample app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #841. This PR adds support for returning JavaKit-wrapped Java objects (like
JavaLongorJavaString) from Swift functions back to Java.Approach
translateResult,translateOptionalResult, andtranslateArrayResultin bothNativeTranslationandJavaTranslationto recognize types passing theisSwiftJavaWrapperpredicate.java.lang.Long) rather than throwing an unsupported type error.Optional, and calls.getJNIValue(in: environment)to safely extract and return the underlying JNI object reference (orNULLif missing).JNIJavaKitTestsfor functions returning standard wrappers, optional wrappers, and arrays of wrappers.