generate extensions of wrapper types owned by other modules - #852
Open
Tatenda-k wants to merge 2 commits into
Open
generate extensions of wrapper types owned by other modules#852Tatenda-k wants to merge 2 commits into
Tatenda-k wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##What
Teaches
wrap-javato generate a Swiftextensionof a wrapper type that is defined in a different Swift module, containing only the members whose signatures or return type references at least one type wrapped by the module being generated.Opt in per-module via a new manifest field:
"extendForeginclasses": ["java.lang.Class"]
Scope/Follow-up
This PR adds the capability + tests. It does not yet delete the hand-written
JavaClass+Reflection.swift: thewrap-javatool itself calls several of thoseJavaClassmethods, so the generatedJavaClass+Extensions.swiftmust beproduced and committed (a one-time bootstrap) before the hand-written file can be
trimmed. Tracked as follow-up.
addresses #18