[AI Bundle][Platform] Allow a custom model catalog on the Ollama platform#2173
Draft
chr-hertel wants to merge 2 commits into
Draft
[AI Bundle][Platform] Allow a custom model catalog on the Ollama platform#2173chr-hertel wants to merge 2 commits into
chr-hertel wants to merge 2 commits into
Conversation
…latform The model_catalog configuration key, previously honored only by the generic, openresponses, and bedrock platforms, now works on every platform that ships a catalog (openai, anthropic, gemini, mistral, ...). A shared resolveModelCatalog() helper applies the override consistently, and each platform config gains the model_catalog node. ollama and elevenlabs build their catalog at runtime and remain the exceptions.
…form Adds an optional $modelCatalog parameter to Ollama\Factory (after $httpClient, matching the other bridge factories), defaulting to the runtime API catalog. The bundle's ollama platform now accepts a model_catalog override, so it is no longer an exception; elevenlabs remains the only one.
carsonbot
added
AI Bundle
carsonbot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Stacked on #2172 — please review/merge that first. This PR's own change is the last commit (the Ollama support); the diff shows #2172 underneath until it merges.
Ollama\Factory::createProvider()andcreatePlatform()gain an optional$modelCatalogparameter (after$httpClient, matching the other bridge factories), defaulting to the runtime API-basedModelCatalog. The bundle'sollamaplatform now accepts amodel_catalogoverride too, so it is no longer an exception — handy for wrapping the API catalog inCachedModelCatalog. Onlyelevenlabsremains.The new parameter shifts later positional arguments by one; all in-repo callers already use named args, and
UPGRADE.mddocuments the change.