feat: reset pathfinding scores before probes#181
Open
piotr-iohk wants to merge 4 commits into
Open
Conversation
3 tasks
Collaborator
Author
|
@cursor review |
Collaborator
Author
|
@cursor review |
Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
@cursor review |
Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a13a025. Configure here.
pwltr
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
PROBE_RESET_SCORESsupport to the mainnet probe spec, so each run can start from a fresh pathfinding scorer.Description
PROBE_RESET_SCORES=true(defaultfalse), the probe spec calls the newresetScoresdevtools method after wallet restore and before readiness: the app stops the node, deletes thescorerandexternal_pathfinding_scores_cacheVSS keys, and restarts the nodelatestPathfindingScoresSyncTimestampmust be at mostPROBE_SCORES_SYNC_MAX_AGE_S(default 900s) old and newer than the reset start time, guarding against a failed external scores fetch silently producing a "no scores" run (the sync timestamp persisted in node metrics survives the restart)scoresSyncto the readiness summary andScores resetto the probe reportPROBE_RESET_SCORES,PROBE_RESET_SCORES_TIMEOUT_SECONDS,PROBE_SCORES_SYNC_MAX_AGE_S, andPROBE_RESET_SCORES_METHODindocs/mainnet-probe.mdWithout the reset, locally learned scores accumulate in VSS under the probe seed across runs (probe results train the scorer), so consecutive scorer A/B runs are not comparable.
Pairs with:
QA Notes
Manual Tests
PROBE_RESET_SCORES=trueagainst a mainnet e2e APK: reset completes (~7s), readiness satisfied with freshscoresSynctimestamp, probes run.regression:run withoutPROBE_RESET_SCORES: behavior unchanged (no reset, no scores sync gating).Automated Checks
Made with Cursor