iris-gui: add bundled feature + "Use embedded PROM" control; add notarized entitlements#34
Open
danifunker wants to merge 2 commits into
Open
iris-gui: add bundled feature + "Use embedded PROM" control; add notarized entitlements#34danifunker wants to merge 2 commits into
bundled feature + "Use embedded PROM" control; add notarized entitlements#34danifunker wants to merge 2 commits into
Conversation
Add a `bundled` cargo feature for pre-compiled/distributed builds: it hides the iris.toml import/export menu items (the GUI's gui.json machine store is the system of record; iris.toml only makes sense alongside the standalone `iris` CLI, i.e. a source checkout). `appstore` now implies `bundled`. A no-op for source builds, where the iris.toml workflow stays available. Also add an explicit "Use embedded PROM" button to the General config tab, so reverting from a custom (possibly missing) PROM is discoverable instead of requiring the path to be cleared by hand. This needed config tabs to report a `ConfigAction` back to the app for the confirmation modal.
Entitlements for the Developer ID / notarized DMG + CLI builds (hardened runtime + allow-unsigned-executable-memory, so the Cranelift JIT works under the hardened runtime). Distinct from the App Store entitlements, which are sandboxed and JIT-less.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small, self-contained additions, both no-ops for a normal source build.
bundledcargo feature (iris-gui)A new
bundledfeature for pre-compiled / distributed binaries. It hides theiris.tomlimport/export menu items, since in a distributed build the GUI'sgui.jsonmachine store is the system of record —iris.tomlis only usefulalongside the standalone
irisCLI (i.e. a source checkout).appstorenowimplies
bundled. For source builds the feature is off and theiris.tomlworkflow is unchanged.
"Use embedded PROM" button (iris-gui General tab)
Leaving the PROM path empty already boots the built-in PROM, but that wasn't
discoverable — you had to clear the field by hand. This adds an explicit
"Use embedded PROM" button (disabled when already empty) with a confirmation
prompt. To support the confirm modal, config tabs now return a
ConfigActionto the app instead of nothing; all existing tabs return
ConfigAction::None.Notarized-distribution entitlements (installer)
Adds
installer/iris-gui-notarized.entitlementsfor Developer ID / notarizedDMG + CLI builds: hardened runtime plus
allow-unsigned-executable-memory, sothe Cranelift JIT keeps working under the hardened runtime. This is distinct
from the App Store entitlements (sandboxed, JIT-less). Validated with
plutil -lint.No behavior change for existing source builds or
cargo run.