Skip to content

Refactors sliding window code#4900

Merged
Duncanma merged 4 commits into
mainfrom
taonic/fix_sliding_window_pattern
Jul 16, 2026
Merged

Refactors sliding window code#4900
Duncanma merged 4 commits into
mainfrom
taonic/fix_sliding_window_pattern

Conversation

@taonic

@taonic taonic commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Collapses the two counters (inFlight + pendingSignals) into one active count carried across continueAsNew, replacing the separate "fill first" phase with a single slide loop gated on active < windowSize.
  • Children read the parent's workflow ID from context instead of taking it as an argument.
  • Termination simplifies to waiting for active == 0.

┆Attachments: EDU-6733 Refactors sliding window code

@taonic
taonic requested a review from a team as a code owner July 16, 2026 13:21
@vercel

vercel Bot commented Jul 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
temporal-documentation Ready Ready Preview, Comment Jul 16, 2026 4:22pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

📖 Docs PR preview links

@joshmsmith joshmsmith left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, it does clarify and simplify the pattern. Very good, thank you.

@Duncanma
Duncanma enabled auto-merge (squash) July 16, 2026 16:20
@Duncanma
Duncanma merged commit 8a7d19e into main Jul 16, 2026
12 checks passed
@Duncanma
Duncanma deleted the taonic/fix_sliding_window_pattern branch July 16, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants