fix(client): generate update id client-side when not provided#773
Open
xepozz wants to merge 1 commit into
Open
fix(client): generate update id client-side when not provided#773xepozz wants to merge 1 commit into
xepozz wants to merge 1 commit into
Conversation
WorkflowStub::startUpdate() sent an empty update id and relied on the
Temporal frontend to assign one. The frontend does; the Java time-skipping
test server does not — the empty id reaches the worker, which panics
("update id is empty, can't validate update"), failing the update workflow
task in a retry loop and wedging the whole execution. The update result
never returns and subsequent signals stop being processed (issue #577).
Generate the id client-side via Common\Uuid::v4() when the caller did not
supply one, matching sdk-go, sdk-java and sdk-typescript.
Adds a functional regression test that runs an update against the
time-skipping test server (WithoutTimeSkipping).
Closes #577
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Generate the id client-side via Common\Uuid::v4() when the caller did not supply one, matching sdk-go, sdk-java and sdk-typescript.
Checklist
Closes [Bug] Can't run the tests of UpdateMethod #577
How was this tested: