Skip to content

Clarify determinism of wait_condition with comment #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sushisource wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clarify determinism of wait_condition with comment #1638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions temporalio/workflow/_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,6 +928,10 @@ async def wait_condition(
This function returns when the callback returns true (invoked each loop
iteration) or the timeout has been reached.

Importantly, using a `0` or `None` value for `timeout` means that no Temporal timer is created.
This means changing from either of those values to a positive value (or the inverse) constitutes
a nondeterministic change to workflow code.

Args:
fn: Non-async callback that accepts no parameters and returns a boolean.
timeout: Optional number of seconds to wait until throwing
Expand Down
Loading