Add patch activation callback#1639
Open
Sushisource wants to merge 1 commit into
Open
Conversation
Sushisource
force-pushed
the
patch-activation-callback
branch
2 times, most recently
from
2be3b0a to
d1ca3f5
Compare
Sushisource
force-pushed
the
patch-activation-callback
branch
from
d1ca3f5 to
477ca3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added an experimental
Worker(..., patch_activation_callback=...)option that lets a worker decide whether the first newly encountered, non-replayworkflow.patchedcall activates a patch.The callback receives frozen
PatchActivationInputcontaining workflow information and the patch ID. Its strict boolean decision is memoized for the workflow run. Declined patches returnFalsewithout recording a marker, while replay, existing history markers, and deprecated patches retain their existing behavior. Replayers do not invoke the callback.This ports the behavior introduced by temporalio/sdk-ruby#481.
Why?
This allows workflow changes using
workflow.patchedto roll out gradually without every new-code worker immediately recording a marker that older workers cannot replay.Testing