Migrate worker_registry_test.go#10564
Open
stephanos wants to merge 2 commits into
Open
Conversation
stephanos
force-pushed
the
stephanos/migrate-worker_registry_test
branch
3 times, most recently
from
cdee574 to
0cefc48
Compare
stephanos
commented
Jun 5, 2026
| // - targetWorkerDeploymentVersionChanged == false (the bug being fixed) | ||
| func (s *Versioning3Suite) TestInlinePath_StableRouting_NoSpuriousFlag() { | ||
| env := s.setupEnv() | ||
| ctx := s.Context() |
stephanos
force-pushed
the
stephanos/migrate-worker_registry_test
branch
9 times, most recently
from
7e1dc33 to
ced4842
Compare
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
stephanos
force-pushed
the
stephanos/migrate-worker_registry_test
branch
from
ced4842 to
157077a
Compare
stephanos
commented
Jun 6, 2026
| testcore.WithDynamicConfig(dynamicconfig.WorkerHeartbeatsEnabled, true), | ||
| } | ||
| env := testcore.NewEnv(s.T(), append(baseOpts, opts...)...) | ||
| tv := testvars.New(s.T()).WithTaskQueue(env.WorkerTaskQueue()).WithNamespaceName(env.Namespace()) |
Contributor
Author
There was a problem hiding this comment.
this might actually be a good default for tv! not making this change here but worth considering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WISOTT