Extract clients from onebox.go#10575
Open
stephanos wants to merge 1 commit into
Open
Conversation
stephanos
force-pushed
the
stephanos/rm-onebox-no-frontend-refs
branch
from
aad7a7f to
93b572b
Compare
stephanos
changed the title
stephanos
force-pushed
the
stephanos/rm-onebox-no-frontend-refs
branch
from
93b572b to
f2ca271
Compare
stephanos
commented
Jun 6, 2026
| temporal.TraceExportModule, | ||
| temporal.ServiceTracingModule, | ||
| frontend.Module, | ||
| fx.Populate(&namespaceRegistry, &rpcFactory, &historyRawClient, &matchingRawClient, &schedulerClient, &grpcResolver), |
Contributor
Author
There was a problem hiding this comment.
Removing these is the goal of this PR.
stephanos
force-pushed
the
stephanos/rm-onebox-no-frontend-refs
branch
11 times, most recently
from
58b8046 to
a77cd06
Compare
stephanos
changed the title
stephanos
force-pushed
the
stephanos/rm-onebox-no-frontend-refs
branch
from
a77cd06 to
3429510
Compare
stephanos
commented
Jun 6, 2026
stephanos
commented
Jun 6, 2026
Comment on lines
+72
to
+75
| func (c *clients) OperatorClient() operatorservice.OperatorServiceClient { | ||
| c.ensureFrontend() | ||
| return c.frontend.operator | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Most tests don't need all these so they are lazy now.
stephanos
force-pushed
the
stephanos/rm-onebox-no-frontend-refs
branch
from
3429510 to
0098273
Compare
stephanos
commented
Jun 6, 2026
Comment on lines
-375
to
-377
| s.testCluster.host.grpcClientInterceptor.Set(func(ctx context.Context) context.Context { | ||
| return metadata.AppendToOutgoingContext(ctx, "temporal-test-name", s.T().Name()) | ||
| }) |
Contributor
Author
There was a problem hiding this comment.
moved this into testcontext
stephanos
force-pushed
the
stephanos/rm-onebox-no-frontend-refs
branch
from
0098273 to
5d26988
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
onebox.gonow creates its frontend/admin/operator, history/scheduler, and matching test clients directly from the configured test hosts.Why?
This removes the
fx.Populatereferences. One step closer to the goal of deleting the separateonebox.gofx graph all-together and making use of the production fx graph from thetemporalpackage instead.