Added unzip to check_dependencies#535
Open
eliaskickbush wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a check for existence of the
unzipbinary incheck_dependenciesto fail early when unzip is not present and give a more explicit error message.While it's uncommon for systems to not have
unzippresent, a fresh installation of WSL does not have unzip, at least in my distribution. The current behavior goes as follows:With this change, a check runs before attempting to unzip (by the already present
check_dependencies). The new user experience is:commandis present onsh, so it should be usable in BSD systems. I have however not checked in an actual BSD-based system.Issue Link
I have not created an issue for this PR.
Testing
./test/run.shlocally and all tests passPlatform tested:
Quality Checklist
Disclaimer
This is my first contribution to this project, sorry if something is off standard, I tried to follow the README.md on contributing. Cheers!