ASoC: SOF: ipc4: Add decoder for RESOURCE_EVENT notifications from fi…#5842
Open
ujfalusi wants to merge 1 commit into
Open
ASoC: SOF: ipc4: Add decoder for RESOURCE_EVENT notifications from fi…#5842ujfalusi wants to merge 1 commit into
ujfalusi wants to merge 1 commit into
Conversation
…rmware Decode and print out the content of currently supported RESOURCE_EVENT notifications from firmware along with the needed data structures and definitions. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
There was a problem hiding this comment.
Pull request overview
Adds decoding support for IPC4 RESOURCE_EVENT notifications in the SOF IPC4 receive path, so driver debug logs include interpreted resource/event information (and raw payload for unknown event types).
Changes:
- Add a
SOF_IPC4_NOTIFY_RESOURCE_EVENThandler that decodes supported event payloads and logs details viadev_dbg(). - Introduce IPC4 resource/event type enums and event-specific payload structures, replacing the raw
u32 data[6]with a typed union. - Wire the new handler into
sof_ipc4_rx_msg()forSOF_IPC4_NOTIFY_RESOURCE_EVENTnotifications.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sound/soc/sof/ipc4.c | Adds a resource event notification handler and connects it in the IPC4 RX notification switch. |
| include/sound/sof/ipc4/header.h | Adds resource/event enums and typed payload definitions for resource event notifications. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+303
to
+305
| return "resource: EDF_TASK"; | ||
| case SOF_IPC4_INVALID_RESOURCE_TYPE: | ||
| return "INVALID_RESOURCE_TYPE"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rmware
Decode and print out the content of currently supported RESOURCE_EVENT notifications from firmware along with the needed data structures and definitions.