More pathpattern test cases#388
Merged
Merged
Conversation
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
jku
force-pushed
the
more-pathpattern-tests
branch
from
c6fd3eb to
647de87
Compare
wolfv
added a commit
to wolfv/sigstore-rust
that referenced
this pull request
Jun 3, 2026
Per the TUF spec, PATHPATTERN wildcards use shell-glob semantics: a `*` matches within a path segment but does not cross `/` (the spec's own example notes `*.tgz` matches `foo.tgz` but not `targets/foo.tgz`). The previous code used globset's default options, where `*` spans `/` (like plain fnmatch), which over-authorizes delegations. Enable globset's `literal_separator` so `*`/`?` stop at `/`. The current tuf-conformance delegation tree (`releases/*/*`, `releases/x/*`) already assumes this and still resolves correctly; this also aligns with the additional cases in theupdateframework/tuf-conformance#388. Thanks to @jku for catching this. Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
wolfv
added a commit
to wolfv/sigstore-rust
that referenced
this pull request
Jun 12, 2026
Per the TUF spec, PATHPATTERN wildcards use shell-glob semantics: a `*` matches within a path segment but does not cross `/` (the spec's own example notes `*.tgz` matches `foo.tgz` but not `targets/foo.tgz`). The previous code used globset's default options, where `*` spans `/` (like plain fnmatch), which over-authorizes delegations. Enable globset's `literal_separator` so `*`/`?` stop at `/`. The current tuf-conformance delegation tree (`releases/*/*`, `releases/x/*`) already assumes this and still resolves correctly; this also aligns with the additional cases in theupdateframework/tuf-conformance#388. Thanks to @jku for catching this. Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
wolfv
added a commit
to sigstore/sigstore-rust
that referenced
this pull request
Jun 16, 2026
Per the TUF spec, PATHPATTERN wildcards use shell-glob semantics: a `*` matches within a path segment but does not cross `/` (the spec's own example notes `*.tgz` matches `foo.tgz` but not `targets/foo.tgz`). The previous code used globset's default options, where `*` spans `/` (like plain fnmatch), which over-authorizes delegations. Enable globset's `literal_separator` so `*`/`?` stop at `/`. The current tuf-conformance delegation tree (`releases/*/*`, `releases/x/*`) already assumes this and still resolves correctly; this also aligns with the additional cases in theupdateframework/tuf-conformance#388. Thanks to @jku for catching this. Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
Member
Author
|
I'm merging this: please file an issue if you see a problem later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.