Skip to content

Version Packages#8808

Open
joaquim-verges wants to merge 1 commit into
mainfrom
changeset-release/main
Open

Version Packages#8808
joaquim-verges wants to merge 1 commit into
mainfrom
changeset-release/main

Conversation

@joaquim-verges

@joaquim-verges joaquim-verges commented Jun 15, 2026

Copy link
Copy Markdown
Member

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@thirdweb-dev/nebula@0.2.117

Patch Changes

  • Updated dependencies [8c521aa]:
    • thirdweb@5.120.2

thirdweb@5.120.2

Patch Changes

  • #8807 8c521aa Thanks @Yash094! - Fix: injected wallets (e.g. MetaMask) no longer fire a spurious "disconnect" event for transient EIP-1193 error code 1013 ("disconnected, will reconnect"). Previously, MetaMask's temporary disconnect during chain changes or RPC hiccups would trigger the thirdweb disconnect subscriber and tear down wallet state, causing unexpected logouts. The onDisconnect handler now ignores code-1013 errors and lets MetaMask reconnect automatically.

    Additionally, the WalletEmitterEvents["disconnect"] type is updated from never to WalletDisconnectError | undefined, so disconnect subscribers can inspect the underlying EIP-1193 error code and message when they need to distinguish disconnect causes.

@thirdweb-dev/wagmi-adapter@0.2.214

wagmi-inapp@0.0.59

Patch Changes

  • Updated dependencies [8c521aa]:
    • thirdweb@5.120.2
    • @thirdweb-dev/wagmi-adapter@0.2.214

PR-Codex overview

This PR focuses on updating package versions and changelogs across multiple packages, specifically addressing improvements in handling wallet disconnections and updating dependencies.

Detailed summary

  • Removed fix-injected-wallet-transient-disconnect.md.
  • Updated version in packages/thirdweb/package.json from 5.120.1 to 5.120.2.
  • Updated version in apps/wagmi-demo/package.json from 0.0.58 to 0.0.59.
  • Updated version in packages/nebula/package.json from 0.2.116 to 0.2.117.
  • Updated version in packages/wagmi-adapter/package.json from 0.2.213 to 0.2.214.
  • Added changelog entries for packages/nebula, apps/wagmi-demo, and packages/thirdweb detailing the updates and fixes related to wallet disconnections.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes
    • Fixed injected wallets (e.g., MetaMask) incorrectly firing spurious disconnect events during transient reconnects, preventing unnecessary wallet state disruption.
    • Enhanced disconnect event typing to expose error details, allowing applications to better distinguish disconnect causes.

@joaquim-verges joaquim-verges requested review from a team as code owners June 15, 2026 15:26
@vercel

vercel Bot commented Jun 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs-v2 Ready Ready Preview, Comment Jun 15, 2026 3:36pm
nebula Ready Ready Preview, Comment Jun 15, 2026 3:36pm
thirdweb_playground Ready Ready Preview, Comment Jun 15, 2026 3:36pm
thirdweb-www Ready Ready Preview, Comment Jun 15, 2026 3:36pm
wallet-ui Ready Ready Preview, Comment Jun 15, 2026 3:36pm

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a16e31b6-e9d0-451d-98a5-48d92cee00bc

📥 Commits

Reviewing files that changed from the base of the PR and between 8c521aa and eb36c3d.

📒 Files selected for processing (9)
  • .changeset/fix-injected-wallet-transient-disconnect.md
  • apps/wagmi-demo/CHANGELOG.md
  • apps/wagmi-demo/package.json
  • packages/nebula/CHANGELOG.md
  • packages/nebula/package.json
  • packages/thirdweb/CHANGELOG.md
  • packages/thirdweb/package.json
  • packages/wagmi-adapter/CHANGELOG.md
  • packages/wagmi-adapter/package.json
💤 Files with no reviewable changes (1)
  • .changeset/fix-injected-wallet-transient-disconnect.md

Walkthrough

This PR publishes release artifacts for thirdweb@5.120.2: a changeset file is removed and changelog entries plus version bumps are applied across thirdweb, wagmi-adapter, nebula, and wagmi-demo packages. The documented fix suppresses spurious EIP-1193 code 1013 disconnect events for injected wallets and updates the WalletEmitterEvents["disconnect"] type.

Changes

Release: thirdweb 5.120.2 and dependent package bumps

Layer / File(s) Summary
thirdweb 5.120.2 changelog and version bump
packages/thirdweb/CHANGELOG.md, packages/thirdweb/package.json
Adds a 5.120.2 patch changelog entry documenting the EIP-1193 code 1013 transient disconnect suppression and WalletEmitterEvents["disconnect"] type update; bumps version from 5.120.1 to 5.120.2.
Dependent package version bumps and changelogs
packages/wagmi-adapter/CHANGELOG.md, packages/wagmi-adapter/package.json, packages/nebula/CHANGELOG.md, packages/nebula/package.json, apps/wagmi-demo/CHANGELOG.md, apps/wagmi-demo/package.json
Bumps wagmi-adapter to 0.2.214, nebula to 0.2.117, and wagmi-demo to 0.0.59, each with changelog entries recording the updated thirdweb dependency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • thirdweb-dev/js#8807: Contains the actual code changes this release PR is publishing — the injected wallet onDisconnect handler update to ignore EIP-1193 error code 1013 and the WalletEmitterEvents["disconnect"] payload type change to WalletDisconnectError | undefined.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title 'Version Packages' is vague and generic, providing no meaningful information about the specific changes or packages being released. Use a more descriptive title that reflects the main purpose, such as 'Release: Fix injected wallet transient disconnect issue' or follow the template format: '[SDK] Fix: Injected wallets transient disconnect'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The PR description is auto-generated by Changesets action and includes detailed release notes, but does not follow the repository's required template with sections like 'Notes for the reviewer' and 'How to test'.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch changeset-release/main

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.70%. Comparing base (8c521aa) to head (eb36c3d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8808   +/-   ##
=======================================
  Coverage   52.69%   52.70%           
=======================================
  Files         934      934           
  Lines       62979    62979           
  Branches     4143     4144    +1     
=======================================
+ Hits        33187    33192    +5     
+ Misses      29692    29687    -5     
  Partials      100      100           
Flag Coverage Δ
packages 52.70% <ø> (+<0.01%) ⬆️
see 2 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 105.66 KB (0%)
@thirdweb-dev/nexus (cjs) 319.47 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant