Skip to content

testdata: attempt to deflake timers/goroutines tests#5384

Open
jakebailey wants to merge 1 commit into
tinygo-org:devfrom
jakebailey:fix-flaky-tests
Open

testdata: attempt to deflake timers/goroutines tests#5384
jakebailey wants to merge 1 commit into
tinygo-org:devfrom
jakebailey:fix-flaky-tests

Conversation

@jakebailey
Copy link
Copy Markdown
Member

Fixes #4963
Fixes #4965

I got tired of hitting these flakes locally and in CI. These changes seem to make them pass, but it's a little unclear without more eyes whether or not I have defeated the purpose of these tests somehow as I of course arrived here after these were committed...

@deadprogram
Copy link
Copy Markdown
Member

I also find those failures very annoying. The tests are not so precise as to preclude these changes. Anyone have any objections for me to squash/merge?

@aykevl
Copy link
Copy Markdown
Member

aykevl commented May 27, 2026

This kinda does defeat the original purpose of these tests. I wrote them a long time ago to show that TinyGo worked concurrently.

What about only running this test on systems without thread support? I don't think they're flaky there.

@deadprogram
Copy link
Copy Markdown
Member

I think perhaps now that I have increased the runner sizes this should be less of a problem for the CI.

@jakebailey
Copy link
Copy Markdown
Member Author

I hit this frequently when doing local testing, so I don't think increasing a builder size really fixes it...

@jakebailey
Copy link
Copy Markdown
Member Author

What about only running this test on systems without thread support? I don't think they're flaky there.

Pushed that, at least

@deadprogram
Copy link
Copy Markdown
Member

@jakebailey can you please rebase against the latest dev to rerun the tests? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

goroutines.go may be flaky timers.go may be flaky

3 participants