Add type and gloss fields#98
Merged
Merged
Conversation
…rn in `sources-prod.yml` to line up with new metadata structure
…l` patterns for the new fields
…s for purposes of counting annotated entries
…ate_type_and_gloss`
…now respects empty strings in unset fields
Contributor
Author
|
Tentatively, my plan is to merge this sometime between 24 and 36 hours from now. In the meantime, I'm happy to go through the changes with whomever so desires. |
dembim
changed the title
type and gloss to back-end; minimal front-end changestype and gloss fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
typeandglossfields to the back-end, separating that data frombody(e.g. when ingesting from toaq/dictionary), and modifies the front-end to use the new fields in displaying and editing results.Anyhow, marking this as draft, because I'd like some more eyes (and time testing).