Force a User-Agent string that is NOT the default Python-urlib.#138
Merged
Conversation
…led to the connection being dropped.
lschuermann
approved these changes
Feb 26, 2026
lschuermann
left a comment
lschuermann
left a comment
Member
There was a problem hiding this comment.
Providing a custom user agent is a good idea.
Can you check whether there are any other uses of urllib in the code that we should adjust?
Contributor
Author
Just checked. The other use is validating if the string is an URL and that won't access any site. So this should be it. |
Contributor
Author
|
@bradjc - what do you think of this PR? |
bradjc
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default user-agent led to the connection being dropped.
This is especially annoying since the rampup documentation is telling you to download the tab from an URL and then that doesn't work.
Not sure if there are any other implications here, but at least the demo blink now works to be downloaded. I think this is annoying enough to warrant a release, actually, but your call.
Credit for the fix goes to Claude, but I was the one wondering what the heck was going on and why the doc instructions were failing.