cache prepared SVG shapes for faster renders#585
Closed
treeform wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
Closing: the SVG-level PreparedShapes cache only helps repeated newImage(svg) on the same parsed Svg. The bench times that path; one-shot tiger renders do not benefit. Will pursue real rasterizer hot-path work instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
newImage(svg)time infillShapesscanlines, with tessellation and segment partitioning rebuilt on every path every render.PreparedShapesso solid fills can reuse cached scanline partitions, pluspolygonsForFill/polygonsForStrokehelpers.newImage(svg)calls skip path tessellation, paint allocation, and color reparsing.Benchmark
nim r -d:danger tests/bench_svg.nim(Ghostscript Tiger, parse once / render many):pixie-grok): ~5.8 ms minTest plan
nim r -d:danger tests/bench_svg.nimnim r -d:danger tests/test_svg.nim(xray masters match)Made with Cursor