Grok: speed up path fill scratch and solid SVG paints#588
Open
treeform wants to merge 1 commit into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
newImage(svg)on the same parsed Svg, not one-shot tiger renders.invMfor partition edge solves (multiply instead of divide).fillScratchbuffers across the many paths inside one SVG render (segments, partitions, hits, coverages).solveXinstead of line intersects.fillPath/strokePathoverloads so SVG solid fills skipPaintallocation.Why this helps one-shot renders
A single Ghostscript Tiger render fills ~240 paths. Scratch reuse amortizes allocations within that one render, not across bench iterations.
invMand Paint avoidance also pay off on the first (and only) draw.Benchmark
nim r -d:danger tests/bench_svg.nim:Test plan
nim r -d:danger tests/bench_svg.nimnim r -d:danger tests/test_svg.nim(xray masters match)Made with Cursor