Skip to content

Add feature flags for Pinecone, Cloudinary, and GitLab OAuth detectors #4961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
camgunz wants to merge 10 commits into
base: main
Choose a base branch
from
+34 −5
Open

Add feature flags for Pinecone, Cloudinary, and GitLab OAuth detectors #4961

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f5044d1
Add feature flags for new detectors
camgunz May 13, 2026
74693aa
Slight rename, ensure the flags are false by default
camgunz May 13, 2026
33d2de1
Missed a name change
camgunz May 13, 2026
507a910
Turn on new detectors for OSS user
camgunz May 14, 2026
bc94a70
Merge branch 'main' into feature-flag-new-detectors
camgunz May 14, 2026
ae049c3
Instead of only adding flagged detectors when their flag is enabled, …
camgunz May 14, 2026
77bc17a
Merge branch 'main' into feature-flag-new-detectors
camgunz May 15, 2026
bd1f593
Thank you cursorbot
camgunz May 15, 2026
e9b3095
Excempt the flagged detectors from a test
camgunz May 20, 2026
e59c77d
Merge branch 'main' into feature-flag-new-detectors
camgunz May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,11 @@ func run(state overseer.State, logSync func() error) {
// OSS Default using github graphql api for issues, pr's and comments
feature.UseGithubGraphQLAPI.Store(false)

// New detector flags
feature.PineconeDetectorEnabled.Store(true)
feature.CloudinaryDetectorEnabled.Store(true)
feature.GitLabOAuthDetectorEnabled.Store(true)

conf := &config.Config{}
if *configFilename != "" {
var err error
Expand Down
26 changes: 19 additions & 7 deletions pkg/engine/defaults/defaults.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ import (
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/atera"
atlassianv1 "github.com/trufflesecurity/trufflehog/v3/pkg/detectors/atlassian/v1"
atlassianv2 "github.com/trufflesecurity/trufflehog/v3/pkg/detectors/atlassian/v2"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/atlassiandatacenter/bitbucketdatacenter"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/atlassiandatacenter/confluencedatacenter"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/atlassiandatacenter/jiradatacenterpat"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/audd"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/auth0managementapitoken"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/auth0oauth"
Expand Down Expand Up @@ -96,7 +99,6 @@ import (
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/billomat"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/bingsubscriptionkey"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/bitbar"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/atlassiandatacenter/bitbucketdatacenter"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/bitbucketapppassword"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/bitcoinaverage"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/bitfinex"
Expand Down Expand Up @@ -188,7 +190,6 @@ import (
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/commercejs"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/commodities"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/companyhub"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/atlassiandatacenter/confluencedatacenter"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/confluent"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/contentfulpersonalaccesstoken"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/conversiontools"
Expand Down Expand Up @@ -402,7 +403,6 @@ import (
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/ipquality"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/ipstack"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/jdbc"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/atlassiandatacenter/jiradatacenterpat"
jiratokenv1 "github.com/trufflesecurity/trufflehog/v3/pkg/detectors/jiratoken/v1"
jiratokenv2 "github.com/trufflesecurity/trufflehog/v3/pkg/detectors/jiratoken/v2"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/jotform"
Expand Down Expand Up @@ -866,11 +866,12 @@ import (
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/zohocrm"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/zonkafeedback"
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/zulipchat"
"github.com/trufflesecurity/trufflehog/v3/pkg/feature"
"github.com/trufflesecurity/trufflehog/v3/pkg/pb/detector_typepb"
)

func buildDetectorList() []detectors.Detector {
return []detectors.Detector{
dets := []detectors.Detector{
&abyssale.Scanner{},
// &abstract.Scanner{},
&abuseipdb.Scanner{},
Expand Down Expand Up @@ -1045,7 +1046,6 @@ func buildDetectorList() []detectors.Detector {
&cloudflarecakey.Scanner{},
&cloudflareglobalapikey.Scanner{},
&cloudimage.Scanner{},
&cloudinary.Scanner{},
&cloudmersive.Scanner{},
&cloudplan.Scanner{},
&cloudsmith.Scanner{},
Expand Down Expand Up @@ -1219,7 +1219,6 @@ func buildDetectorList() []detectors.Detector {
&gitlabv1.Scanner{},
&gitlabv2.Scanner{},
&gitlabv3.Scanner{},
&gitlaboauth2.Scanner{},
&gitter.Scanner{},
&glassnode.Scanner{},
&gocanvas.Scanner{},
Expand Down Expand Up @@ -1453,7 +1452,6 @@ func buildDetectorList() []detectors.Detector {
&photoroom.Scanner{},
&phraseaccesstoken.Scanner{},
&pinata.Scanner{},
&pinecone.Scanner{},
&pipedream.Scanner{},
&pipedrive.Scanner{},
&pivotaltracker.Scanner{},
Expand Down Expand Up @@ -1766,6 +1764,20 @@ func buildDetectorList() []detectors.Detector {
&zonkafeedback.Scanner{},
&zulipchat.Scanner{},
}

if feature.PineconeDetectorEnabled.Load() {
dets = append(dets, &pinecone.Scanner{})
}

if feature.CloudinaryDetectorEnabled.Load() {
dets = append(dets, &cloudinary.Scanner{})
}

if feature.GitLabOAuthDetectorEnabled.Load() {
dets = append(dets, &gitlaboauth2.Scanner{})
}
Comment thread
camgunz marked this conversation as resolved.
Outdated

return dets
}

func DefaultDetectors() []detectors.Detector {
Expand Down
3 changes: 3 additions & 0 deletions pkg/feature/feature.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ var (
GitlabProjectsPerPage atomic.Int64
UseGithubGraphQLAPI atomic.Bool // use github graphql api to fetch issues, pr's and comments
HTMLDecoderEnabled atomic.Bool
PineconeDetectorEnabled atomic.Bool
CloudinaryDetectorEnabled atomic.Bool
GitLabOAuthDetectorEnabled atomic.Bool
)

type AtomicString struct {
Expand Down
Loading