Added scan_version feature flag to sharepoint proto#4972
Added scan_version feature flag to sharepoint proto#4972MuneebUllahKhan222 wants to merge 2 commits into
Conversation
gugacyber
left a comment
There was a problem hiding this comment.
The poto changes look correct — field numbers 3, 4, 5 are fresh and don't conflict with existing fields, and the raw descriptor bytes in sources.pb.go are consistent with the new fields.
One thing worth noting: the three new flags default to false (protobuf bool default), meaning existing configs silently opt out of scanning versions, comments, and attachments after upgrading. If the previous behavior was to scan these by default, this is a silent breaking change for existing users. Worth documenting in the PR whether the old behavior scanned these or not, and if so, defaulting to true or adding a migration note.
Also, the PR description mentions scan_version (singular) but the field added is scan_versions (plural) — minor inconsistency in the description.
Description:
This PR introduces a
scan_version,scan_comments,scan_attachmentssource configs flags for sharepoint source in soures.protos file.Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Medium Risk
Adds a new
boolfield to theSharepointprotobuf message, which changes the public proto/API surface and requires downstream regeneration/compatibility consideration, but does not alter runtime logic beyond message shape.Overview
Adds a SharePoint feature flag to the API schema. The
Sharepointproto now includes ascan_versionsboolean field, and the generated Go protobuf (sources.pb.go) and validation stubs (sources.pb.validate.go) are updated accordingly (including a newGetScanVersions()accessor).Reviewed by Cursor Bugbot for commit 1031d26. Bugbot is set up for automated code reviews on this repo. Configure here.