Skip to content

Added scan_version feature flag to sharepoint proto#4972

Open
MuneebUllahKhan222 wants to merge 2 commits into
mainfrom
sharepoint-proto-update
Open

Added scan_version feature flag to sharepoint proto#4972
MuneebUllahKhan222 wants to merge 2 commits into
mainfrom
sharepoint-proto-update

Conversation

@MuneebUllahKhan222
Copy link
Copy Markdown
Contributor

@MuneebUllahKhan222 MuneebUllahKhan222 commented May 18, 2026

Description:

This PR introduces a scan_version, scan_comments, scan_attachments source configs flags for sharepoint source in soures.protos file.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

Note

Medium Risk
Adds a new bool field to the Sharepoint protobuf message, which changes the public proto/API surface and requires downstream regeneration/compatibility consideration, but does not alter runtime logic beyond message shape.

Overview
Adds a SharePoint feature flag to the API schema. The Sharepoint proto now includes a scan_versions boolean field, and the generated Go protobuf (sources.pb.go) and validation stubs (sources.pb.validate.go) are updated accordingly (including a new GetScanVersions() accessor).

Reviewed by Cursor Bugbot for commit 1031d26. Bugbot is set up for automated code reviews on this repo. Configure here.

@MuneebUllahKhan222 MuneebUllahKhan222 requested a review from a team May 18, 2026 14:44
@MuneebUllahKhan222 MuneebUllahKhan222 requested review from a team as code owners May 18, 2026 14:44
Copy link
Copy Markdown

@gugacyber gugacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poto changes look correct — field numbers 3, 4, 5 are fresh and don't conflict with existing fields, and the raw descriptor bytes in sources.pb.go are consistent with the new fields.
One thing worth noting: the three new flags default to false (protobuf bool default), meaning existing configs silently opt out of scanning versions, comments, and attachments after upgrading. If the previous behavior was to scan these by default, this is a silent breaking change for existing users. Worth documenting in the PR whether the old behavior scanned these or not, and if so, defaulting to true or adding a migration note.
Also, the PR description mentions scan_version (singular) but the field added is scan_versions (plural) — minor inconsistency in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants