fix: remove 'or True' bypass in AuthorizationMiddleware#312
Open
Joshua-Medvinsky wants to merge 1 commit into
Open
fix: remove 'or True' bypass in AuthorizationMiddleware#312Joshua-Medvinsky wants to merge 1 commit into
Joshua-Medvinsky wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the LLMStack Team on Vercel. A member of the Team first needs to authorize it. |
Signed-off-by: FailSafe Researcher <joshua@getfailsafe.com>
aae183d to
420472f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
AuthorizationMiddlewarecontainsor Truein the signature verification condition, making it always truthy. Combined with the baseAppTypeInterface.verify_request_signature()which returnsTrueunconditionally, all POST requests to/api/apps/*/runbypass signature verification. An unauthenticated attacker can invoke any app's run endpoint directly.Fix
Remove
or Truefrom the condition inauthorization_middleware.pyline 30. This restores the intended behavior: only requests with valid Discord or Slack signatures proceed to verification; other requests pass through without triggering the verification block.Test Plan
/api/apps/*/runare no longer forced into the signature verification blockSecurity Note
Severity: Critical — This allows unauthenticated invocation of any LLMStack app endpoint, potentially exposing LLM API keys, user data, and app outputs.