Limestone rewrite - #46
Conversation
e75f573 to
e3c7ccb
Compare
|
To do:
|
|
Fixes #57 |
…ndingaid into limestone-rewrite
…ove social-media-links override
a632b97 to
0279a7b
Compare
… when scope and contents exist
Accordion / component renderingComponents are now collapsible only when they have sub-components. Previously if an accordion had a note (scope/bioghist/processinfo), a leaf component was wrapped with an accordion with nothing to expand into. Now leaves should render like other components at the top level without an accordion heading. We drafted a few versions of the accordions, including versions with vertical guidelines for user wayfinding in deep hierarchies. In alignment with team feedback, we opted for a borderless presentation to keep a clean UI, and added a separator component from UK's Web Platform to better differentiate sibling components. There is also a bit of JS written to make accordions work correctly; the original limestone component was not made with the intention of nesting. Images / mediaWe are now using Limestone's masonry component for image galleries and added a provisional alt text for images that is derived from the title of the component they are found in (e.g., "Garrett Watts (1796-1873) correspondence, 1848 (image 1 of 5)"). This isn't great, but it is something while we have a lot of content without proper descriptors. Video and audio buttons now ship with icons indicating content type, as well as aria-labels for accessibility purposes. Video sizing is also handled by CSS, instead of hardcoded values. Header/ footerThere are a few improvements to the styles in the website search box and footer. These will need to be duplicated over to exploreuk-web-app as we currently don't have a way to share that code. Accessibility FixesThere are many more accessibility fixes in the work. Aria-labels for buttons, new provisional alt text, limestone overrides, and general sizing fixes. Nested sub-components now use aria-levels for headings past |
Related to this exploreuk-web-app PR, this pull request is a full UI rewrite of the findingaid. This rewrite is primarily for addressing accessibility concerns.
This PR fixes #7, fixes #8, fixes #9, fixes #10, fixes #22, fixes #24, fixes #33, fixes #34, fixes #35,