Skip to content

Fix resource leaks in Connection#1713

Draft
rblenkinsopp wants to merge 3 commits into
developfrom
rcb/connection-rework
Draft

Fix resource leaks in Connection#1713
rblenkinsopp wants to merge 3 commits into
developfrom
rcb/connection-rework

Conversation

@rblenkinsopp

@rblenkinsopp rblenkinsopp commented Apr 30, 2026

Copy link
Copy Markdown
Member

This makes a number oc changes to improve Connection teardown logic:

  • Fixed a file descriptor leak in Connection that exhausted the Unity process's OS handle limit after repeated play-mode start/stop cycles.
  • Fixed an unmanaged memory leak where the marshalled server namespace string passed to LeapC was not freed.
  • Fixed a managed memory leak in Controller where event subscriptions on the pooled Connection were not removed on disposal.
  • Fixed a missing timeout on Connection shutdown which could lead to delays in applications exiting.

@rblenkinsopp rblenkinsopp force-pushed the rcb/connection-rework branch from 56c8dce to 3ba0cff Compare June 2, 2026 13:45
@rblenkinsopp rblenkinsopp changed the title Rework connection teardown logic Fix resource leaks in Connection Jun 2, 2026
@rblenkinsopp rblenkinsopp force-pushed the rcb/connection-rework branch from 3ba0cff to 6ccc3c1 Compare June 10, 2026 08:53
@MaxPalmer-UH

Copy link
Copy Markdown
Collaborator

From a testing perspective looks like this sorts the file descriptor issue from unity when stop/starting in MacOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants