Skip to content

Refactor docs publishing into reusable shared workflow#738

Merged
rlepinski merged 1 commit into
mainfrom
on-demand-docs-publish
May 12, 2026
Merged

Refactor docs publishing into reusable shared workflow#738
rlepinski merged 1 commit into
mainfrom
on-demand-docs-publish

Conversation

@jyaganeh

@jyaganeh jyaganeh commented May 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Extracts the docs and deploy-docs jobs from the release workflow into a new reusable workflow at .github/workflows/publish-docs.yml
  • The shared workflow supports workflow_call (triggered automatically on tag push) and workflow_dispatch (manual republish for any existing tag), both checking out ref: inputs.version
  • Updates release.yml to call the shared workflow via a single publish-docs job with secrets: inherit
  • Upgrades GCP auth from deprecated setup-gcloud@v0 to google-github-actions/auth@v2 + setup-gcloud@v2
  • Adds a notify-release job at the end of the release workflow for Slack notifications on success/failure/cancellation

Test plan

  • Verify workflow_dispatch trigger appears for publish-docs.yml in the GitHub Actions UI with a version input field
  • Trigger a manual run against an existing tag and confirm docs build, GCS upload, and GitHub Pages deploy succeed
  • Confirm the next tag-push release runs publish-docs and notify-release correctly

🤖 Generated with Claude Code

Extracts doc build/deploy into .github/workflows/publish-docs.yml,
callable via workflow_call (on tag push) or workflow_dispatch (manual
republish for any existing tag). Updates release workflow to call it
and adds a notify-release job for Slack notifications.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@jyaganeh jyaganeh requested a review from a team as a code owner May 9, 2026 00:23
with:
node-version-file: .nvmrc

- name: Setup GCP Auth

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just temp right? dual deploy until its in?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. I'll circle back to remove all the old docs upload stuff once we've got everything publishing to pages

@rlepinski rlepinski merged commit b3aed1c into main May 12, 2026
1 check passed
@rlepinski rlepinski deleted the on-demand-docs-publish branch May 12, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants