Skip to content

Add Embedded views screen#740

Merged
khmMouna merged 5 commits into
mainfrom
MOBILE-4973-Align-embeddedView-sizing
May 28, 2026
Merged

Add Embedded views screen#740
khmMouna merged 5 commits into
mainfrom
MOBILE-4973-Align-embeddedView-sizing

Conversation

@khmMouna

@khmMouna khmMouna commented May 18, 2026

Copy link
Copy Markdown
Contributor
Simulator Screenshot - iPhone 17 Pro - 2026-05-18 at 16 59 12 Simulator Screenshot - iPhone 17 Pro - 2026-05-18 at 16 59 50 Screenshot_1779116329 Screenshot_1779116389

@khmMouna khmMouna requested a review from a team as a code owner May 18, 2026 16:01
@khmMouna khmMouna marked this pull request as draft May 18, 2026 16:06
@khmMouna khmMouna self-assigned this May 19, 2026
@khmMouna khmMouna marked this pull request as ready for review May 19, 2026 13:27
Comment thread example/package.json Outdated
"react-native": "0.84.0",
"react-native-safe-area-context": "^5.6.2"
"react-native-safe-area-context": "^5.6.2",
"react-native-vector-icons": "^10.3.0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-native-vector-icons is deprecated on npm, is there something newer to use?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the replacement is the scoped packages under @react-native-vector-icons/*. So, usage becomes:

import Ionicons from ‘@react-native-vector-icons/material-icons’;
instead of:
import Ionicons from ‘react-native-vector-icons/MaterialIcons’;

@khmMouna khmMouna requested review from Apekka and crow May 28, 2026 10:12
@khmMouna khmMouna merged commit b70d289 into main May 28, 2026
1 check passed
@khmMouna khmMouna deleted the MOBILE-4973-Align-embeddedView-sizing branch May 28, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants