feat: support utopia-php/storage 3.0#209
Merged
Merged
Conversation
- getType() comparisons use the DeviceType enum instead of the removed Storage::DEVICE_LOCAL constant (JSON and CSV sources) - setTransferChunkSize() was removed upstream; the chunk size is now passed per transfer() call (JSON and CSV destinations) - Require utopia-php/storage 3.* and PHP >= 8.5 (the storage floor) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Greptile SummaryThis PR updates the migration library for storage 3.0. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "feat: support utopia-php/storage 3.0" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts utopia-php/storage 3.0.0. Three changes:
getType()now returns theDeviceTypeenum, so the JSON and CSV sources compare againstDeviceType::Localinstead of the removedStorage::DEVICE_LOCALconstant.setTransferChunkSize()was removed upstream in favour of a per-call argument: the JSON and CSV destinations passTransfer::STORAGE_MAX_CHUNK_SIZEtotransfer()directly.composer.jsonrequiresutopia-php/storage: 3.*andphp: >=8.5(storage 3.0's floor — a version bump signal for maintainers: this likely warrants a minor at least).Why
This release unblocks the Appwrite migration to storage 3.0 (appwrite/appwrite#12921), which is currently draft because this package pins
storage 2.*.Testing
composer lint(pint) passescomposer check(PHPStan level 3, src + tests) passes — it caught the twosetTransferChunkSize()calls a plain grep missedLocaldevice transfer path🤖 Generated with Claude Code